‹ 首页

requesting-code-review

@obra · 收录于 1 周前 · 上游提交 2 周前

Use when completing tasks, implementing major features, or before merging to verify work meets requirements

适合你,如果你需要在合并代码前确保工作符合要求

/ 通过 npx 安装 校验哈希
npx oh-my-skill add obra/superpowers/requesting-code-review
/ 通过 bash 安装
curl -fsSL https://oh-my-skill.com/install.sh | bash -s -- obra/superpowers/requesting-code-review
/ 已经装过?验证本机副本,不用重装
npx oh-my-skill verify obra/superpowers/requesting-code-review
安装目标可用 --agent / --scope 或 --to 明确指定;省略时只会在唯一已存在的 agent 目录上自动选择,零命中或多命中会停止并提示。content_hash 缺失或不一致均拒装。
250996GitHub stars
~571最小装载
~1.6K含声明引用
~1.6K文本包总量
索引托管

怎么用

商店整理自技能原文 · 版本 d884ae0 · 表述以原文为准
它做什么

安装后,Claude 会在你完成代码任务后,自动派一个代码审查助手来检查你的代码,找出问题并给出改进建议。

什么时候触发

当你完成一个子任务、实现主要功能,或准备合并代码到主分支时触发。

装好后可以这样说
Claude 会派审查助手检查当前代码变更。
确保代码质量后再合并。
审查助手可能提供新思路。
技能原文 SKILL.md作者撰写 · MIT · d884ae0

Requesting Code Review

Dispatch a code reviewer subagent to catch issues before they cascade. The reviewer gets precisely crafted context for evaluation — never your session's history. This keeps the reviewer focused on the work product, not your thought process, and preserves your own context for continued work.

Core principle: Review early, review often.

When to Request Review

Mandatory:

  • After each task in subagent-driven development
  • After completing major feature
  • Before merge to main

Optional but valuable:

  • When stuck (fresh perspective)
  • Before refactoring (baseline check)
  • After fixing complex bug
How to Request

1. Get git SHAs:

BASE_SHA=$(git rev-parse HEAD~1)  # or origin/main
HEAD_SHA=$(git rev-parse HEAD)

2. Dispatch code reviewer subagent:

Dispatch a general-purpose subagent, filling the template at [code-reviewer.md](code-reviewer.md)

Placeholders:

  • {DESCRIPTION} - Brief summary of what you built
  • {PLAN_OR_REQUIREMENTS} - What it should do
  • {BASE_SHA} - Starting commit
  • {HEAD_SHA} - Ending commit

3. Act on feedback:

  • Fix Critical issues immediately
  • Fix Important issues before proceeding
  • Note Minor issues for later
  • Push back if reviewer is wrong (with reasoning)
Example
[Just completed Task 2: Add verification function]

You: Let me request code review before proceeding.

BASE_SHA=$(git log --oneline | grep "Task 1" | head -1 | awk '{print $1}')
HEAD_SHA=$(git rev-parse HEAD)

[Dispatch code reviewer subagent]
  DESCRIPTION: Added verifyIndex() and repairIndex() with 4 issue types
  PLAN_OR_REQUIREMENTS: Task 2 from docs/superpowers/plans/deployment-plan.md
  BASE_SHA: a7981ec
  HEAD_SHA: 3df7661

[Subagent returns]:
  Strengths: Clean architecture, real tests
  Issues:
    Important: Missing progress indicators
    Minor: Magic number (100) for reporting interval
  Assessment: Ready to proceed

You: [Fix progress indicators]
[Continue to Task 3]
Integration with Workflows

Subagent-Driven Development:

  • Review after EACH task
  • Catch issues before they compound
  • Fix before moving to next task

Executing Plans:

  • Review after each task or at natural checkpoints
  • Get feedback, apply, continue

Ad-Hoc Development:

  • Review before merge
  • Review when stuck
Red Flags

Never:

  • Skip review because "it's simple"
  • Ignore Critical issues
  • Proceed with unfixed Important issues
  • Argue with valid technical feedback

If reviewer wrong:

  • Push back with technical reasoning
  • Show code/tests that prove it works
  • Request clarification

See template at: [code-reviewer.md](code-reviewer.md)

按 MIT 许可原样转载,未经改动 · 在 GitHub 查看 →

评论

登录即可评论;带「已验证安装」的,是发布者名下有本店的安装或持有记录。