security-triage

Security Triage

Use when reviewing CrawClaw security advisories, drafts, or GHSA reports.

Goal: high-confidence maintainers' triage without over-closing real issues or shipping unnecessary regressions.

Close Bar

Close only if one of these is true:

• duplicate of an existing advisory or fixed issue
• invalid against shipped behavior
• out of scope under SECURITY.md
• fixed before any affected release/tag

Do not close only because main is fixed. If latest shipped tag or npm release is affected, keep it open until released or published with the right status.

Required Reads

Before answering:

1. Read SECURITY.md.
2. Read the GHSA body with gh api /repos/crawclaw/crawclaw/security-advisories/<GHSA>.
3. Inspect the exact implicated code paths.
4. Verify shipped state:
5. git tag --sort=-creatordate | head
6. npm view crawclaw version --userconfig "$(mktemp)"
7. git tag --contains <fix-commit>
8. if needed: git show <tag>:path/to/file
9. Search for canonical overlap:
10. existing published GHSAs
11. older fixed bugs
12. same trust-model class already covered in SECURITY.md

Review Method

For each advisory, decide:

• close
• keep open
• keep open but narrow

Check in this order:

1. Trust model
2. Is the prerequisite already inside trusted host/local/plugin/operator state?
3. Does SECURITY.md explicitly call this class out as out of scope or hardening-only?
4. Shipped behavior
5. Is the bug present in the latest shipped tag or npm release?
6. Was it fixed before release?
7. Exploit path
8. Does the report show a real boundary bypass, not just prompt injection, local same-user control, or helper-level semantics?
9. Functional tradeoff
10. If a hardening change would reduce intended user functionality, call that out before proposing it.
11. Prefer fixes that preserve user workflows over deny-by-default regressions unless the boundary demands it.

Response Format

When preparing a maintainer-ready close reply:

1. Print the GHSA URL first.
2. Then draft a detailed response the maintainer can post.
3. Include:
4. exact reason for close
5. exact code refs
6. exact shipped tag / release facts
7. exact fix commit or canonical duplicate GHSA when applicable
8. optional hardening note only if worthwhile and functionality-preserving

Keep tone firm, specific, non-defensive.

Clipboard Step

After drafting the final post body, copy it:

pbcopy <<'EOF'
<final response>
EOF

Tell the user that the clipboard now contains the proposed response.

Useful Commands

gh api /repos/crawclaw/crawclaw/security-advisories/<GHSA>
gh api /repos/crawclaw/crawclaw/security-advisories --paginate
git tag --sort=-creatordate | head -n 20
npm view crawclaw version --userconfig "$(mktemp)"
git tag --contains <commit>
git show <tag>:<path>
gh search issues --repo crawclaw/crawclaw --match title,body,comments -- "<terms>"
gh search prs --repo crawclaw/crawclaw --match title,body,comments -- "<terms>"

Decision Notes

• “fixed on main, unreleased” is usually not a close.
• “needs attacker-controlled trusted local state first” is usually out of scope.
• “same-host same-user process can already read/write local state” is usually out of scope.
• “helper function behaves differently than documented config semantics” is usually invalid.
• If only the severity is wrong but the bug is real, keep it open and narrow the impact in the reply.